Ver Fonte

fix: 修复JS数据集动态参数自动填充的问题,以及处理参数替换异常的情况

wu.jian2 há 1 ano atrás
pai
commit
2a1ff039fb

+ 9 - 4
data-room-ui/packages/DataSetManagement/src/JsComponents/ParamsSettingDialog.vue

@@ -171,6 +171,11 @@ export default {
       default: () => []
       default: () => []
     }
     }
   },
   },
+  computed: {
+    innerParamsList () {
+      return cloneDeep(this.paramsList)
+    }
+  },
   data () {
   data () {
     return {
     return {
       dialogVisible: false
       dialogVisible: false
@@ -187,7 +192,7 @@ export default {
       this.dialogVisible = false
       this.dialogVisible = false
     },
     },
     addParam () {
     addParam () {
-      this.paramsList.push({
+      this.innerParamsList.push({
         name: '',
         name: '',
         type: '',
         type: '',
         value: '',
         value: '',
@@ -197,10 +202,10 @@ export default {
       })
       })
     },
     },
     delRow (index) {
     delRow (index) {
-      this.paramsList.splice(index, 1)
+      this.innerParamsList.splice(index, 1)
     },
     },
     checkParamsName (value) {
     checkParamsName (value) {
-      const checkList = this.paramsList.filter(item => item.fieldName === value.name)
+      const checkList = this.innerParamsList.filter(item => item.fieldName === value.name)
       if (checkList.length) {
       if (checkList.length) {
         this.$message.warning('参数名称不可以与字段名相同!')
         this.$message.warning('参数名称不可以与字段名相同!')
         value.name = ''
         value.name = ''
@@ -210,7 +215,7 @@ export default {
       this.dialogVisible = false
       this.dialogVisible = false
     },
     },
     confirm () {
     confirm () {
-      this.$emit('saveParams', cloneDeep(this.paramsList))
+      this.$emit('saveParams', this.innerParamsList)
       this.dialogVisible = false
       this.dialogVisible = false
     }
     }
   }
   }

+ 23 - 19
data-room-ui/packages/DataSetManagement/src/JsEditForm.vue

@@ -432,6 +432,7 @@ export default {
       })
       })
     }
     }
     return {
     return {
+      autoFill: true,
       dataForm: {
       dataForm: {
         id: '',
         id: '',
         name: '',
         name: '',
@@ -642,7 +643,9 @@ export default {
         try {
         try {
           const scriptAfterReplacement = javascript.replace(/\${(.*?)}/g, (match, p) => {
           const scriptAfterReplacement = javascript.replace(/\${(.*?)}/g, (match, p) => {
             const value = this.dataForm.config.paramsList.find(param => param.name === p).value
             const value = this.dataForm.config.paramsList.find(param => param.name === p).value
-            if (!isNaN(value)) {
+            if (value === null || value === undefined || value === '') {
+              return "''"
+            } else if (!isNaN(value)) {
               return value
               return value
             } else {
             } else {
               return `'${value}'`
               return `'${value}'`
@@ -654,8 +657,8 @@ export default {
           this.passTest = false
           this.passTest = false
           const javascriptParams = javascript.match(/\${(.*?)}/g)
           const javascriptParams = javascript.match(/\${(.*?)}/g)
           // 取出${}中的参数名
           // 取出${}中的参数名
+          let paramList = []
           if (javascriptParams) {
           if (javascriptParams) {
-            const paramList = []
             javascriptParams.forEach(item => {
             javascriptParams.forEach(item => {
               const name = item.replace(/\${(.*?)}/g, '$1')
               const name = item.replace(/\${(.*?)}/g, '$1')
               const param = this.dataForm.config.paramsList.find(param => param.name === name)
               const param = this.dataForm.config.paramsList.find(param => param.name === name)
@@ -664,24 +667,12 @@ export default {
                 paramList.push(name)
                 paramList.push(name)
               }
               }
             })
             })
-            this.$confirm(`脚本中的参数${paramList.join(',')}不存在,是否添加?`, '提示', {
-              confirmButtonText: '确定',
-              cancelButtonText: '取消',
-              customClass: 'bs-el-message-box',
-              type: 'warning'
-            }).then(() => {
-              paramList.forEach(name => {
-                this.dataForm.config.paramsList.push({
-                  name,
-                  type: '',
-                  value: '',
-                  status: 1,
-                  require: 0,
-                  remark: ''
-                })
-              })
-            }).catch(() => {})
+            if (this.autoFill && paramList.length > 0) {
+              this.addParams(paramList)
+              paramList = []
+            }
           } else {
           } else {
+            console.info(error)
             this.$message.error(`脚本执行错误,请检查脚本,具体错误:${error}`)
             this.$message.error(`脚本执行错误,请检查脚本,具体错误:${error}`)
           }
           }
           return
           return
@@ -762,6 +753,19 @@ export default {
         this.$message.error('请填写脚本')
         this.$message.error('请填写脚本')
       }
       }
     },
     },
+    addParams (paramList) {
+      this.$refs.paramsSettingDialog.open()
+      paramList.forEach(name => {
+        this.dataForm.config.paramsList.push({
+          name,
+          type: '',
+          value: '',
+          status: 1,
+          require: 0,
+          remark: ''
+        })
+      })
+    },
     // 执行事件
     // 执行事件
     // toExecute () {
     // toExecute () {
     // if (this.dataForm.config.paramsList.length) {
     // if (this.dataForm.config.paramsList.length) {

+ 6 - 3
data-room-ui/packages/js/mixins/commonMixins.js

@@ -156,8 +156,9 @@ export default {
               try {
               try {
                 const scriptAfterReplacement = res.data.script.replace(/\${(.*?)}/g, (match, p) => {
                 const scriptAfterReplacement = res.data.script.replace(/\${(.*?)}/g, (match, p) => {
                   const value = this.config.dataSource?.params[p]
                   const value = this.config.dataSource?.params[p]
-
-                  if (!isNaN(value)) {
+                  if (value === null || value === undefined || value === '') {
+                    return "''"
+                  } else if (!isNaN(value)) {
                     return value || p
                     return value || p
                   } else {
                   } else {
                     return `'${value}' || '${p}'`
                     return `'${value}' || '${p}'`
@@ -224,7 +225,9 @@ export default {
               try {
               try {
                 const scriptAfterReplacement = res.data.script.replace(/\${(.*?)}/g, (match, p) => {
                 const scriptAfterReplacement = res.data.script.replace(/\${(.*?)}/g, (match, p) => {
                   const value = this.config.dataSource?.params[p]
                   const value = this.config.dataSource?.params[p]
-                  if (!isNaN(value)) {
+                  if (value === null || value === undefined || value === '') {
+                    return "''"
+                  } else if (!isNaN(value)) {
                     return value || p
                     return value || p
                   } else {
                   } else {
                     return `'${value}' || '${p}'`
                     return `'${value}' || '${p}'`