Browse Source

代码优化

hubin 1 year ago
parent
commit
b8312ed57a

+ 2 - 1
src/main/java/com/aizuda/boot/modules/common/controller/OssController.java

@@ -11,6 +11,7 @@ import org.springframework.web.bind.annotation.*;
 import org.springframework.web.multipart.MultipartFile;
 
 import java.net.URLEncoder;
+import java.nio.charset.StandardCharsets;
 
 @Tag(name = "oss文件存储")
 @RestController
@@ -37,7 +38,7 @@ public class OssController {
     public void download(HttpServletResponse response, String objectName) {
         try {
             response.setHeader("Content-Disposition", "attachment;filename=" +
-                    URLEncoder.encode(objectName, "UTF-8"));
+                    URLEncoder.encode(objectName, StandardCharsets.UTF_8));
             fileStorage.download(response, objectName);
         } catch (Exception e) {
             e.printStackTrace();

+ 3 - 2
src/main/java/com/aizuda/boot/modules/system/service/impl/SysUserServiceImpl.java

@@ -32,6 +32,7 @@ import org.springframework.stereotype.Service;
 import org.springframework.transaction.annotation.Transactional;
 
 import java.util.Arrays;
+import java.util.Collections;
 import java.util.List;
 
 /**
@@ -110,7 +111,7 @@ public class SysUserServiceImpl extends BaseServiceImpl<SysUserMapper, SysUser>
         // 分配角色
         AssignRolesParam assignRolesParam = new AssignRolesParam();
         assignRolesParam.setRoleIds(param.getRoleIds());
-        assignRolesParam.setUserIds(Arrays.asList(param.getId()));
+        assignRolesParam.setUserIds(Collections.singletonList(param.getId()));
         return sysUserRoleService.assignRoles(assignRolesParam);
     }
 
@@ -118,7 +119,7 @@ public class SysUserServiceImpl extends BaseServiceImpl<SysUserMapper, SysUser>
         // 分配部门
         AssignDepartmentsParam assignDepartmentsParam = new AssignDepartmentsParam();
         assignDepartmentsParam.setDepartmentIds(param.getDepartmentIds());
-        assignDepartmentsParam.setUserIds(Arrays.asList(param.getId()));
+        assignDepartmentsParam.setUserIds(Collections.singletonList(param.getId()));
         return sysUserDepartmentService.assignDepartments(assignDepartmentsParam);
     }
 

+ 2 - 2
src/main/java/com/aizuda/boot/modules/ws/WsMessageServer.java

@@ -23,8 +23,8 @@ import java.util.concurrent.ConcurrentHashMap;
 @Component
 @ServerEndpoint(value = "/ws", configurator = WsEndpointConfigurator.class)
 public class WsMessageServer {
-    private static Map<String, WsSession> ONLINE_SESSIONS = new ConcurrentHashMap<>();
-    private static Map<String, String> TOKEN_SESSION_IDS = new ConcurrentHashMap<>();
+    private static final Map<String, WsSession> ONLINE_SESSIONS = new ConcurrentHashMap<>();
+    private static final Map<String, String> TOKEN_SESSION_IDS = new ConcurrentHashMap<>();
 
     /**
      * 客户端打开连接